From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Jones Subject: Re: [2.6 patch] kernel/audit.c: remove unused exports Date: Tue, 28 Nov 2006 12:27:36 -0800 Message-ID: <20061128202736.GA21537@suse.de> References: <20061128012848.GW15364@stusta.de> <20061128191809.GA19990@suse.de> <1164742022.22245.10.camel@pmac.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id kASKTgsL010281 for ; Tue, 28 Nov 2006 15:29:42 -0500 Received: from mx1.suse.de (ns1.suse.de [195.135.220.2]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id kASKTeZK011857 for ; Tue, 28 Nov 2006 15:29:40 -0500 Content-Disposition: inline In-Reply-To: <1164742022.22245.10.camel@pmac.infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: David Woodhouse Cc: linux-audit@redhat.com, Adrian Bunk List-Id: linux-audit@redhat.com On Tue, Nov 28, 2006 at 07:27:02PM +0000, David Woodhouse wrote: > On Tue, 2006-11-28 at 11:18 -0800, Tony Jones wrote: > > I recall the opinion at the time was that it was considered useful to allow > > third party modules to generate audit messages. Has anything changed? > > It should at least be EXPORT_SYMBOL_GPL, not EXPORT_SYMBOL. Agreed. That sounds fine. Tony