From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: [2.6 patch] kernel/audit.c: change the exports to EXPORT_SYMBOL_GPL Date: Mon, 11 Dec 2006 21:42:20 +0100 Message-ID: <20061211204220.GH28443@stusta.de> References: <20061128012848.GW15364@stusta.de> <20061128191809.GA19990@suse.de> <1164742022.22245.10.camel@pmac.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx2.redhat.com (mx2.redhat.com [10.255.15.25]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id kBBKgGrs025078 for ; Mon, 11 Dec 2006 15:42:16 -0500 Received: from mailout.stusta.mhn.de (emailhub.stusta.mhn.de [141.84.69.5]) by mx2.redhat.com (8.12.11.20060308/8.12.11) with SMTP id kBBKgEu7017810 for ; Mon, 11 Dec 2006 15:42:15 -0500 Content-Disposition: inline In-Reply-To: <1164742022.22245.10.camel@pmac.infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: David Woodhouse Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Tue, Nov 28, 2006 at 07:27:02PM +0000, David Woodhouse wrote: > On Tue, 2006-11-28 at 11:18 -0800, Tony Jones wrote: > > I recall the opinion at the time was that it was considered useful to allow > > third party modules to generate audit messages. Has anything changed? > > It should at least be EXPORT_SYMBOL_GPL, not EXPORT_SYMBOL. So let's do at least the minimal patch noone disagrees with. > dwmw2 cu Adrian <-- snip --> This patch changes some completely unused audit exports from EXPORT_SYMBOL to EXPORT_SYMBOL_GPL. They are still completely unused, but hopefully some of the theoretical code that might use it will appear in the kernel in the near future... Signed-off-by: Adrian Bunk --- linux-2.6.19-mm1/kernel/audit.c.old 2006-12-11 20:13:54.000000000 +0100 +++ linux-2.6.19-mm1/kernel/audit.c 2006-12-11 20:14:19.000000000 +0100 @@ -1209,7 +1209,7 @@ } } -EXPORT_SYMBOL(audit_log_start); -EXPORT_SYMBOL(audit_log_end); -EXPORT_SYMBOL(audit_log_format); -EXPORT_SYMBOL(audit_log); +EXPORT_SYMBOL_GPL(audit_log_start); +EXPORT_SYMBOL_GPL(audit_log_end); +EXPORT_SYMBOL_GPL(audit_log_format); +EXPORT_SYMBOL_GPL(audit_log);