From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] audit: fix two bugs in the new execve audit code
Date: Fri, 27 Jul 2007 16:05:41 -0700
Message-ID: <20070727160541.382a4778.akpm@linux-foundation.org>
References: <200707190848.l6J8mFQf023098@imap1.linux-foundation.org>
	<200707271613.10753.sgrubb@redhat.com>
	<1185576918.15205.68.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <1185576918.15205.68.camel@lappy>
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, aaw@google.com, linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Sat, 28 Jul 2007 00:55:18 +0200
Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> -		if (!ret) {
> +		if (ret) {
>  			WARN_ON(1);
>  			send_sig(SIGKILL, current, 0);
>  		}

fwiw, that could now become

	if (WARN_ON(ret))
		send_sig(SIGKILL, current, 0);