From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: [PATCH] audit: fix two bugs in the new execve audit code Date: Fri, 27 Jul 2007 22:05:07 -0400 Message-ID: <200707272205.07788.sgrubb@redhat.com> References: <200707190848.l6J8mFQf023098@imap1.linux-foundation.org> <200707271613.10753.sgrubb@redhat.com> <1185576918.15205.68.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1185576918.15205.68.camel@lappy> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Peter Zijlstra Cc: Andrew Morton , linux-audit@redhat.com, Linus Torvalds , aaw@google.com List-Id: linux-audit@redhat.com On Friday 27 July 2007 18:55:18 Peter Zijlstra wrote: > copy_from_user() returns the number of bytes not copied, hence 0 is the > expected output. > > axi->mm might not be valid anymore when not equal to current->mm, do not > dereference before checking that - thanks to Al for spotting that. > > Signed-off-by: Peter Zijlstra This patch tests good applied to the same rawhide kernel source that reported the problems. -Steve