From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: auparse_interpret_field() Date: Fri, 9 Nov 2007 15:17:58 -0500 Message-ID: <200711091517.59953.sgrubb@redhat.com> References: <1194560760.10377.11.camel@klausk.br.ibm.com> <200711091256.42639.sgrubb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: klausk@br.ibm.com Cc: "Linux-audit@redhat.com" , linux-audit-bounces@redhat.com List-Id: linux-audit@redhat.com On Friday 09 November 2007 14:56:05 klausk@br.ibm.com wrote: > See that 'r->machine' and 'r->syscall' are only filled when the 'arch' > field in found in the 2nd position, and syscall in the 3rd position > respectively. That is not true when the dispatcher is appending a 'node=' > field to each record. Yeah I put a FIXME in the code for that a little while ago. It needs to be flexible. > I would provide a patch myself, but I'm not sure why you need to check the > field position in this function (I mean, if the field is arch=, wouldn't > it be interpreted no matter what position it is?) Speed. I wanted a way to only check these things once and not slow it down for each field. This is where the record is getting split up, so we can do anything but simple checks. -Steve