From: Paul Moore <paul.moore@hp.com>
To: Eric Paris <eparis@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] Audit: Fix the format type for size_t variables
Date: Wed, 27 Feb 2008 12:45:05 -0500 [thread overview]
Message-ID: <200802271245.05595.paul.moore@hp.com> (raw)
In-Reply-To: <1204129321.3206.12.camel@localhost.localdomain>
On Wednesday 27 February 2008 11:22:01 am Eric Paris wrote:
> On Wed, 2008-02-27 at 10:39 -0500, Paul Moore wrote:
> > Fix the following compiler warning by using "%zu" as defined in
> > C99.
> >
> > CC kernel/auditsc.o
> > kernel/auditsc.c: In function 'audit_log_single_execve_arg':
> > kernel/auditsc.c:1074: warning: format '%ld' expects type 'long
> > int', but argument 4 has type 'size_t'
> >
> > Signed-off-by: Paul Moore <paul.moore@hp.com>
>
> I would have sworn I already saw this patch go by. But I don't see
> it in Al's git tree.
Perhaps, but it's still in Linus' tree from a few hours ago.
> Acked-by: Eric Paris <eparis@redhat.com>
>
> > ---
> >
> > kernel/auditsc.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> > index 2087d6d..782262e 100644
> > --- a/kernel/auditsc.c
> > +++ b/kernel/auditsc.c
> > @@ -1070,7 +1070,7 @@ static int audit_log_single_execve_arg(struct
> > audit_context *context, * so we can be sure nothing was lost.
> > */
> > if ((i == 0) && (too_long))
> > - audit_log_format(*ab, "a%d_len=%ld ", arg_num,
> > + audit_log_format(*ab, "a%d_len=%zu ", arg_num,
> > has_cntl ? 2*len : len);
> >
> > /*
> >
> > --
> > Linux-audit mailing list
> > Linux-audit@redhat.com
> > https://www.redhat.com/mailman/listinfo/linux-audit
--
paul moore
linux security @ hp
next prev parent reply other threads:[~2008-02-27 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 15:39 [PATCH] Audit: Fix the format type for size_t variables Paul Moore
2008-02-27 16:22 ` Eric Paris
2008-02-27 17:45 ` Paul Moore [this message]
2008-02-27 17:58 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802271245.05595.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox