From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: The second argument "type" is not used in audit_filter_user() Date: Mon, 19 May 2008 13:11:48 -0400 Message-ID: <200805191311.49294.sgrubb@redhat.com> References: <482D4F73.5080404@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <482D4F73.5080404@cn.fujitsu.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Peng Haitao Cc: linux-audit@redhat.com, dwmw2@infradead.org List-Id: linux-audit@redhat.com On Friday 16 May 2008 05:10:11 am Peng Haitao wrote: > I find the second argument "type" is not used in audit_filter_user(). I researched this all the way back to our RHEL4 kernel. This appears to be in every kernel I can find. I don't know what its original purpose is, but it does appear to be unused. Its not on a performance critical path, but should be cleaned up just on the principal of it. Someone should submit a patch deleting this argument. -Steve