From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH] fix a bug that option '-i' cannot be used
Date: Fri, 25 Jul 2008 14:22:48 -0400
Message-ID: <200807251422.49483.sgrubb@redhat.com>
References: <48816289.4060500@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <48816289.4060500@cn.fujitsu.com>
Content-Disposition: inline
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Yu Zhiguo <yuzg@cn.fujitsu.com>
Cc: audit-list <linux-audit@redhat.com>
List-Id: linux-audit@redhat.com

Hello Yu,

On Friday 18 July 2008 23:42:01 Yu Zhiguo wrote:
> =C2=A0 Option '-i' cannot be used, because the check about option '-R'
> in main() is wrong.
> =C2=A0 When check option '-R', we should consider whether option '-i'
> is specified.

I was just looking at this patch. The intention with the -R option is for=
 it=20
to be given saying that all options will be read from the file. You shoul=
d be=20
able to place "-i" on a line by itself within the file and it should igno=
re=20
errors. This would be similar to the way the -D option is given by itself=
=20
near the top of a typical rule file.

I agree with some of the cleanup that this patch suggests and will apply =
that=20
part. But I think the intent was for "-i" to be in the file and not the=20
command line.

Thanks,
-Steve