From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] Fix the bug of using AUDIT_STATUS_RATE_LIMIT when set fail, no error output. Date: Thu, 31 Jul 2008 14:59:34 -0700 Message-ID: <20080731145934.cc3893de.akpm@linux-foundation.org> References: <48911F47.50606@cn.fujitsu.com> <1217474150.2902.76.camel@localhost.localdomain> <20080731160438.GK28946@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080731160438.GK28946@ZenIV.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Al Viro Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com List-Id: linux-audit@redhat.com On Thu, 31 Jul 2008 17:04:38 +0100 Al Viro wrote: > On Wed, Jul 30, 2008 at 11:15:50PM -0400, Eric Paris wrote: > > On Thu, 2008-07-31 at 10:11 +0800, zhangxiliang wrote: > > > When the "status_get->mask" is "AUDIT_STATUS_RATE_LIMIT || AUDIT_STATUS_BACKLOG_LIMIT". > > > If "audit_set_rate_limit" fails and "audit_set_backlog_limit" succeeds, the "err" value will be greater than or equal to 0. It will miss the failure of rate set. > > > > > > Signed-off-by: Zhang Xiliang > > > > man, it gives me the heebee jeebies with the coding style but it follows > > everything else > > Sanitized, applied, pushed to audit-current (audit.b53) That tree doesn't appear to be in the linux-next lineup. Fixable, please?