From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: [PATCH 1/5] Add the field checking for missing value after opration Date: Wed, 6 Aug 2008 14:59:48 -0400 Message-ID: <200808061459.48637.sgrubb@redhat.com> References: <48995CFA.5020302@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <48995CFA.5020302@cn.fujitsu.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Zhang Xiliang Cc: Linux Audit List-Id: linux-audit@redhat.com On Wednesday 06 August 2008 04:12:42 Zhang Xiliang wrote: >I think the missing value for -F should be checking.=20 > >For example, >auditctl -a exit,always -F pid=3D > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (*v =3D=3D NULL) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0return -20; I changed these to (*v =3D=3D 0) since it is a char and not a pointer. Th= anks for=20 the patch! Applied -Steve