From: Steve Grubb <sgrubb@redhat.com>
To: Eric Paris <eparis@redhat.com>
Cc: 'linux-audit' <linux-audit@redhat.com>
Subject: Re: [Patch]Fix the error in the output of "auditctl -s" when auditd is stoped
Date: Thu, 7 Aug 2008 09:54:30 -0400 [thread overview]
Message-ID: <200808070954.31543.sgrubb@redhat.com> (raw)
In-Reply-To: <1218116377.5837.67.camel@localhost.localdomain>
On Thursday 07 August 2008 09:39:37 Eric Paris wrote:
> > When auditd is stoped, "auditctl -s" will show "pid=0". I think it's
> > not correct information. It's better to tell users "auditd not started".
>
> We do try to keep the whole key=value pair thing in audit records.
This is for the display when you type auditctl -s and doesn't have anything to
do with audit records.
> I'd be willing to go with something like -1 to make it really clear, but
> with the number of complaints about the inconsistencies of audit records
> from people like John Dennis I'm not sure I'm a fan of this patch....
I don't think that's an issue since this is not in the records. My only
concern is what this might do to our test suites. For the moment, I'm just
trying to finish off what we will have in RHEL5 without changes to API that
might cause any regressions in the test suites.
Around the time that Fedora 11 work starts, I'd like to start making changes
to clean things up and have new ideas. That time is coming soon...but not
yet.
-Steve
next prev parent reply other threads:[~2008-08-07 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 4:50 [Patch]Fix the error in the output of "auditctl -s" when auditd is stoped Chu Li
2008-08-07 13:39 ` Eric Paris
2008-08-07 13:54 ` Steve Grubb [this message]
2008-08-07 13:55 ` John Dennis
2008-08-07 21:01 ` Steve Grubb
2008-08-08 1:10 ` Chu Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808070954.31543.sgrubb@redhat.com \
--to=sgrubb@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox