From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: [PATCH]Delete unnecessary codes in auditd-config.c and audispd-pconfig.c Date: Thu, 7 Aug 2008 16:47:04 -0400 Message-ID: <200808071647.05087.sgrubb@redhat.com> References: <005a01c8f845$cda16f00$958da70a@truly> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <005a01c8f845$cda16f00$958da70a@truly> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Chu Li Cc: 'linux-audit' List-Id: linux-audit@redhat.com On Thursday 07 August 2008 00:26:46 Chu Li wrote: > I think such codes about "basename" in auditd-config.c and > audispd-pconfig.c is unnecessary. In these part "nv->value" can't be null > and "basename()" will never return an empty string. And the variable "base" > is not used in the following codes. So such codes are better to be deleted. Applied. Thanks for the patch ! -Steve