From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: [PATCH 1/2] Fix the bug for missing field name before operator Date: Thu, 7 Aug 2008 16:52:51 -0400 Message-ID: <200808071652.51674.sgrubb@redhat.com> References: <489ACF21.8080707@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <489ACF21.8080707@cn.fujitsu.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Zhang Xiliang Cc: Linux Audit List-Id: linux-audit@redhat.com On Thursday 07 August 2008 06:32:01 Zhang Xiliang wrote: > I think the way "f == v" can't make sure that they didn't type -F =10. > After "v = strstr(pair, "=")" and v++. The v will not equal to f. > > It is checked by "audit_name_to_field()", but not "f == v". > Because before v++, the "*v" is set to 0. we can use "*f == 0" to check out > the case. The patch is for it. Applied. Thanks for the patch ! -Steve