From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records Date: Fri, 20 Mar 2009 09:51:25 -0400 Message-ID: <200903200951.25699.paul.moore@hp.com> References: <1666981128.1772561237539207343.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1666981128.1772561237539207343.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Miloslav Trmac Cc: linux-audit@redhat.com, viro , linux-kernel List-Id: linux-audit@redhat.com On Friday 20 March 2009 04:53:27 am Miloslav Trmac wrote: > ----- "Paul Moore" wrote: > > There are several audit experts which should review this code but two > > things jumped out at me when glancing at your patch: > > > > 1. SELinux SIDs should not be recorded > > Almost all code that logs SELinux contexts in kernel/audit* does the same > thing as this patch, falling back to a SID if it can't be converted to a > string. Ungh, that's ugly and questionably useful (I suppose I know why this is done) but if that convention then who am I to argue. > > 2. From a SELinux/security point of view ttys are considered objects > > and their labels/contexts should be recorded with "obj=" not > > "subj=" > > The patch logs the context of the process, not of the TTY. Okay, that is what I get for just glancing at patches and not looking at them closer :) -- paul moore linux @ hp