From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: [RFC PATCH] audit: Fix possible return value truncation in audit_get_context() Date: Wed, 01 Apr 2009 15:47:27 -0400 Message-ID: <20090401194727.9583.7857.stgit@flek.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n31JlqYn008524 for ; Wed, 1 Apr 2009 15:47:52 -0400 Received: from g4t0017.houston.hp.com (g4t0017.houston.hp.com [15.201.24.20]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id n31JlWHY027754 for ; Wed, 1 Apr 2009 15:47:32 -0400 Received: from g1t0038.austin.hp.com (g1t0038.austin.hp.com [16.236.32.44]) by g4t0017.houston.hp.com (Postfix) with ESMTP id 50F9C38118 for ; Wed, 1 Apr 2009 19:47:32 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: linux-audit@redhat.com List-Id: linux-audit@redhat.com The audit subsystem treats syscall return codes as type long, unfortunately the audit_get_context() function mistakenly converts the return code to an int type in the parameters which could cause problems on systems where the sizeof(int) != sizeof(long). Signed-off-by: Paul Moore --- kernel/auditsc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 8cbddff..8d76dfc 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -751,7 +751,7 @@ static void audit_set_auditable(struct audit_context *ctx) static inline struct audit_context *audit_get_context(struct task_struct *tsk, int return_valid, - int return_code) + long return_code) { struct audit_context *context = tsk->audit_context;