From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Viro Subject: Re: [RFC PATCH] audit: Fix possible return value truncation in audit_get_context() Date: Wed, 1 Apr 2009 17:19:41 -0400 Message-ID: <20090401211941.GA19309@shell.devel.redhat.com> References: <20090401194727.9583.7857.stgit@flek.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20090401194727.9583.7857.stgit@flek.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Paul Moore Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Wed, Apr 01, 2009 at 03:47:27PM -0400, Paul Moore wrote: > The audit subsystem treats syscall return codes as type long, unfortunately > the audit_get_context() function mistakenly converts the return code to an > int type in the parameters which could cause problems on systems where the > sizeof(int) != sizeof(long). > > Signed-off-by: Paul Moore Applied. E.g. for mmap() it's actually easy to trigger on 64bit boxen.