From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] this mutex_lock is miss used
Date: Sun, 19 Apr 2009 16:32:28 +0100
Message-ID: <20090419153228.GU26366@ZenIV.linux.org.uk>
References: <20090419140355.GA16609@helight>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1761251AbZDSPcj@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20090419140355.GA16609@helight>
Sender: linux-kernel-owner@vger.kernel.org
To: Zhenwen Xu <helight.xu@gmail.com>
Cc: linux-kernel@vger.kernel.org, eparis@redhat.com, linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Sun, Apr 19, 2009 at 10:03:55PM +0800, Zhenwen Xu wrote:
> 
> This mutex_lock and mutex_unlock has no use in such way.

Incorrect.  They delay sending response until we are out of audit_receive().

> It should be like this way:

No, it should not.  In particular, it should *NOT* be held while sending
these packets.