From: Paul Moore <paul.moore@hp.com>
To: Tony Jones <tonyj@suse.de>
Cc: linux-audit@redhat.com
Subject: Re: Audit not recording the correct syscall return value in Fedora 10?
Date: Tue, 5 May 2009 15:50:01 -0400 [thread overview]
Message-ID: <200905051550.01946.paul.moore@hp.com> (raw)
In-Reply-To: <20090505193443.GA20428@suse.de>
On Tuesday 05 May 2009 03:34:43 pm Tony Jones wrote:
> On Tue, May 05, 2009 at 03:20:52PM -0400, Paul Moore wrote:
> > On Tuesday 05 May 2009 03:07:36 pm Tony Jones wrote:
> > > On Tue, May 05, 2009 at 02:22:04PM -0400, Paul Moore wrote:
> > > > I believe Matt Anderson (CC'd) reported the bug you are referring to
> > > > and the workaround I posted seemed to fix the issue for him. I've
> > > > stopped looking
> > >
> > > I'll check it out, I see the commit:
> > > 6d208da89aabee8502debe842832ca0ab298d16d
> >
> > Well, that commit does solve a return value problem on 64 bit systems but
> > it isn't the workaround I was referring to ... the mail which I sent that
> > started this thread (April 7, 2009) has a small patch to
> > arch/x86/kernel/entry_64.S to load the return value directly from the
> > stack and not %rax to workaround the corruption issue.
>
> Sorry, my bad. I went back to grab the code snippet to check if it was in
> git put pulled it from your earlier (Apr 1) thread by mistake. That said, I
> think it's the issue I'm seeing on x86_64 but I'll try the calling sequence
> fix also.
>
> So what is the status of the entry_64.S fix? Did discussion go beyond this
> list?
>
> Apologies for the confusion.
No problem. As far as I'm aware the discussion never went beyond this thread
as I was unable to recreate the problem with the (then) current kernels but it
may not be a bad idea to get the arch folks and perhaps lkml involved if we
can narrow this down a little.
--
paul moore
linux @ hp
next prev parent reply other threads:[~2009-05-05 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 15:34 Audit not recording the correct syscall return value in Fedora 10? Paul Moore
2009-04-08 2:44 ` Klaus Heinrich Kiwi
2009-04-08 21:38 ` Paul Moore
2009-05-05 18:15 ` Tony Jones
2009-05-05 18:08 ` Tony Jones
2009-05-05 18:22 ` Paul Moore
2009-05-05 19:07 ` Tony Jones
2009-05-05 19:20 ` Paul Moore
2009-05-05 19:34 ` Tony Jones
2009-05-05 19:50 ` Paul Moore [this message]
2009-05-07 23:05 ` Tony Jones
2009-05-08 13:22 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905051550.01946.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=linux-audit@redhat.com \
--cc=tonyj@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox