From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Jones Subject: Re: Audit not recording the correct syscall return value in Fedora 10? Date: Tue, 5 May 2009 12:34:43 -0700 Message-ID: <20090505193443.GA20428@suse.de> References: <200904071134.35379.paul.moore@hp.com> <200905051422.04556.paul.moore@hp.com> <20090505190736.GA18169@suse.de> <200905051520.52317.paul.moore@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n45JYr7J020553 for ; Tue, 5 May 2009 15:34:53 -0400 Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n45JYcbr018153 for ; Tue, 5 May 2009 15:34:39 -0400 Content-Disposition: inline In-Reply-To: <200905051520.52317.paul.moore@hp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Paul Moore Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Tue, May 05, 2009 at 03:20:52PM -0400, Paul Moore wrote: > On Tuesday 05 May 2009 03:07:36 pm Tony Jones wrote: > > On Tue, May 05, 2009 at 02:22:04PM -0400, Paul Moore wrote: > > > I believe Matt Anderson (CC'd) reported the bug you are referring to and > > > the workaround I posted seemed to fix the issue for him. I've stopped > > > looking > > > > I'll check it out, I see the commit: > > 6d208da89aabee8502debe842832ca0ab298d16d > > Well, that commit does solve a return value problem on 64 bit systems but it > isn't the workaround I was referring to ... the mail which I sent that started > this thread (April 7, 2009) has a small patch to arch/x86/kernel/entry_64.S to > load the return value directly from the stack and not %rax to workaround the > corruption issue. Sorry, my bad. I went back to grab the code snippet to check if it was in git put pulled it from your earlier (Apr 1) thread by mistake. That said, I think it's the issue I'm seeing on x86_64 but I'll try the calling sequence fix also. So what is the status of the entry_64.S fix? Did discussion go beyond this list? Apologies for the confusion. Tony