From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Cc: viro@zeniv.linux.org.uk
Subject: Re: [PATCH] Audit: fix audit nlmsg_len from the kernel
Date: Tue, 2 Jun 2009 16:45:02 -0400 [thread overview]
Message-ID: <200906021645.02794.sgrubb@redhat.com> (raw)
In-Reply-To: <1243975082.2923.6.camel@dhcp231-142.rdu.redhat.com>
On Tuesday 02 June 2009 04:38:02 pm Eric Paris wrote:
> > But lets fix it anyway rather than rely on dumb luck and implementation
> > details.
>
> Self NAK. Userspace was also written by someone who didn't know
> netlink. Since userspace is half using the netlink macros and half
> depending on this broken nlmsg_len implementation I don't think we can
> make any changes in the kernel and they wouldn't be backwards
> compatible...
The netlink code is the oldest part of the audit code and predates my
involvement. We could fix this if userspace had a way of querying the kernel to
see what the audit capabilities are. There have been many times that I've
wanted a way to ask the kernel if certain things are supported.
-Steve
next prev parent reply other threads:[~2009-06-02 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 23:17 [PATCH] Audit: fix audit nlmsg_len from the kernel Eric Paris
2009-06-02 20:38 ` Eric Paris
2009-06-02 20:45 ` Steve Grubb [this message]
2009-06-02 20:51 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906021645.02794.sgrubb@redhat.com \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox