From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Blanchard Subject: Re: [PATCH] audit: speedup for syscalls when auditing is disabled Date: Tue, 24 Aug 2010 12:16:26 +1000 Message-ID: <20100824021625.GA2425@kryten> References: <29151.1282270393@neuling.org> <1282586177.2681.43.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1282586177.2681.43.camel@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org To: Eric Paris Cc: Michael Neuling , linux-audit@redhat.com, linux-kernel@vger.kernel.org, Al Viro List-Id: linux-audit@redhat.com Hi Eric, > I don't think this works at all. I don't see how syscall audit'ing can > work. What if I have nothing in the AUDIT_FILTER_TASK list but I want > to audit all 'open(2)' syscalls? This patch is going to leave the task > in the DISABLED state and we won't ever be able to match on the syscall > rules. That's a good point. What if we went through and created an audit context for each thread at the point where we add a rule to the audit subsystem? That would make the common case where no one touches audit go fast. It's only once you add a rule that you get the syscall entry/exit overhead of audit. Anton