From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Jan Engelhardt <jengelh@medozas.de>,
Patrick McHardy <kaber@trash.net>,
netfilter-devel@vger.kernel.org, linux-audit@redhat.com,
Eric Paris <eparis@parisplace.org>, Al Viro <viro@Zen>
Subject: Re: [PATCHv2] netfilter: audit target to record accepted/dropped packets
Date: Sat, 15 Jan 2011 00:10:40 +0100 [thread overview]
Message-ID: <20110114231040.GA12126@rere.qmqm.pl> (raw)
In-Reply-To: <20110114222223.GA22508@canuck.infradead.org>
On Fri, Jan 14, 2011 at 05:22:23PM -0500, Thomas Graf wrote:
> On Fri, Jan 14, 2011 at 06:29:22PM +0100, Jan Engelhardt wrote:
> > On Friday 2011-01-14 17:59, Thomas Graf wrote:
> > >+static int audit_tg_check(const struct xt_tgchk_param *par)
> > >+{
> > >+ const struct xt_AUDIT_info *info = par->targinfo;
> > >+
> > >+ if (info->type > XT_AUDIT_TYPE_MAX) {
> > >+ pr_info("Audit type out of range (valid range: 0..%u)\n",
> > >+ XT_AUDIT_TYPE_MAX);
> > >+ return -ERANGE;
> > >+ }
> > >+
> > >+ return 0;
> > >+}
> > Math nitpick: EDOM, not ERANGE.
> ERANGE is the common error code to use in this situation.
Actually, EINVAL is the correct one here since this is not a math function
and the error does not refer to result of mathematical coputation.
Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-14 23:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 15:20 [PATCH] netfilter: audit target to record accepted/dropped packets Thomas Graf
2011-01-14 15:26 ` Eric Paris
2011-01-14 15:31 ` Jan Engelhardt
2011-01-14 15:37 ` Thomas Graf
2011-01-14 15:46 ` Patrick McHardy
2011-01-14 16:19 ` Thomas Graf
2011-01-14 16:49 ` Jan Engelhardt
2011-01-14 16:59 ` [PATCHv2] " Thomas Graf
2011-01-14 17:29 ` Jan Engelhardt
2011-01-14 22:22 ` Thomas Graf
2011-01-14 23:10 ` Michał Mirosław [this message]
2011-01-14 23:19 ` Jan Engelhardt
2011-01-14 23:16 ` Jan Engelhardt
2011-01-14 22:24 ` [PATCHv3] " Thomas Graf
2011-01-14 23:48 ` [PATCHv4] " Thomas Graf
2011-01-15 16:07 ` Patrick McHardy
2011-01-16 17:12 ` [PATCHv3] " Patrick McHardy
2011-01-14 18:51 ` [PATCHv2] " Mr Dash Four
2011-01-14 19:18 ` Jan Engelhardt
2011-01-14 19:24 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114231040.GA12126@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=eparis@parisplace.org \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=linux-audit@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=viro@Zen \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox