[PATCH v7 41/49] vfs: allow utimensat() calls to retry once on an ESTALE error

Jeff Layton
2012-10-02T00:18:04Z

Clearly, we can't handle the NULL filename case, but we can deal with
the case where there's a real pathname.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/utimes.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/fs/utimes.c b/fs/utimes.c
index fa4dbe4..b6b2865 100644
--- a/fs/utimes.c
+++ b/fs/utimes.c
@@ -156,16 +156,21 @@ long do_utimes(int dfd, const char __user *filename, struct timespec *times,
} else {
struct path path;
int lookup_flags = 0;
+ unsigned int try = 0;

if (!(flags & AT_SYMLINK_NOFOLLOW))
lookup_flags |= LOOKUP_FOLLOW;

- error = user_path_at(dfd, filename, lookup_flags, &path);
- if (error)
- goto out;
+ do {
+ error = user_path_at(dfd, filename,
+ lookup_flags, &path);
+ if (error)
+ break;

- error = utimes_common(&path, times);
- path_put(&path);
+ error = utimes_common(&path, times);
+ path_put(&path);
+ lookup_flags |= LOOKUP_REVAL;
+ } while (retry_estale(error, try++));
}

out:
--
1.7.11.4