From: Jeff Layton <jlayton@redhat.com>
To: Peter Moody <pmoody@google.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] audit: grab a reference to context->pwd when it's cached
Date: Fri, 5 Oct 2012 07:02:23 -0400 [thread overview]
Message-ID: <20121005070223.22e7f95a@tlielax.poochiereds.net> (raw)
In-Reply-To: <CALnj_=4MvywnQFzqfWoYCt=t4AW1dSXaCz6fkDED13C7zdNSvg@mail.gmail.com>
On Thu, 4 Oct 2012 11:48:23 -0700
Peter Moody <pmoody@google.com> wrote:
> On Wed, Sep 26, 2012 at 6:50 AM, Alexander Viro <aviro@redhat.com> wrote:
> > On Tue, Sep 25, 2012 at 10:03:23AM -0700, Peter Moody wrote:
> >> Hey folks,
> >>
> >> following up on old patches, are there any comments on this? Did you
> >> get around to finding a better way to fix this bug, Al?
> >
> > Alas, I've found none ;-/ Looks like we'll have to go with this one,
> > at least until somebody comes up with better solution.
>
> Not surprisingly, this patch doesn't actually fix the issue (or at
> least doesn't do it correctly).
>
> I hadn't noticed that get_fs_pwd() actually calls path_get() on
> &context->pwd so the additional path_get() is useless and the
> reference doesn't ever actually get freed if audit_putname is called
> while we're in a syscall.
>
> Al, Eric, Jeff; do any of you guys have an understanding of what the
> initial bug actually is since this clearly doesn't fix it?
>
> Cheers,
> peter
>
Hrm...so yeah. The chdir call should have pinned the dentry. I think
you'll need to track down where the oops actually occurred.
One way to determine that is to do something like this, but you'll need
to replace the kmod in the instructions with your vmlinux:
https://wiki.samba.org/index.php/LinuxCIFS_troubleshooting#Oopses
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2012-10-05 11:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 1:13 [PATCH] audit: grab a reference to context->pwd when it's cached Peter Moody
2012-08-16 1:26 ` Alexander Viro
2012-08-16 1:41 ` Peter Moody
2012-08-20 17:19 ` Peter Moody
2012-09-25 17:03 ` Peter Moody
2012-09-26 13:50 ` Alexander Viro
2012-09-26 18:20 ` Peter Moody
2012-10-04 18:48 ` Peter Moody
2012-10-05 11:02 ` Jeff Layton [this message]
2012-10-05 12:55 ` Jeff Layton
2012-10-05 13:57 ` Peter Moody
2012-10-05 14:10 ` Jeff Layton
2012-10-05 14:26 ` Jeff Layton
2012-10-05 15:16 ` Peter Moody
2012-10-05 15:18 ` Peter Moody
2012-10-05 15:57 ` Peter Moody
2012-10-05 16:15 ` Jeff Layton
2012-10-05 17:04 ` Peter Moody
2012-10-05 19:41 ` Peter Moody
2012-10-08 12:23 ` Jeff Layton
2012-10-08 15:22 ` Peter Moody
2012-10-08 16:45 ` Peter Moody
2012-10-08 14:10 ` Jeff Layton
2012-10-05 20:23 ` Eric Sandeen
2012-10-07 3:22 ` Peter Moody
2012-10-08 18:48 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005070223.22e7f95a@tlielax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=linux-audit@redhat.com \
--cc=pmoody@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox