Linux-audit Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@canonical.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Eric Paris <eparis@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] audit: printk USER_AVC messages when audit isn't enabled
Date: Fri, 16 Aug 2013 12:05:58 -0700	[thread overview]
Message-ID: <20130816190558.GB3592@boyd> (raw)
In-Reply-To: <1374800575-32320-1-git-send-email-tyhicks@canonical.com>


[-- Attachment #1.1: Type: text/plain, Size: 2513 bytes --]

On 2013-07-25 18:02:55, Tyler Hicks wrote:
> When the audit=1 kernel parameter is absent and auditd is not running,
> AUDIT_USER_AVC messages are being silently discarded.
> 
> AUDIT_USER_AVC messages should be sent to userspace using printk(), as
> mentioned in the commit message of
> 4a4cd633b575609b741a1de7837223a2d9e1c34c ("AUDIT: Optimise the
> audit-disabled case for discarding user messages").
> 
> When audit_enabled is 0, audit_receive_msg() discards all user messages
> except for AUDIT_USER_AVC messages. However, audit_log_common_recv_msg()
> refuses to allocate an audit_buffer if audit_enabled is 0. The fix is to
> special case AUDIT_USER_AVC messages in both functions.
> 
> Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Eric Paris <eparis@redhat.com>
> Cc: linux-audit@redhat.com
> ---

Hello Al and Eric - I wanted to bring this patch back to your attention
so it doesn't get forgotten. This is a fairly nasty bug in distros that
leave auditd as optional but still build packages against libaudit.

Thanks!

Tyler

> 
> It looks like commit 50397bd1e471391d27f64efad9271459c913de87 ("[AUDIT] clean
> up audit_receive_msg()") introduced this bug, so I think that this patch should
> also get the tag:
> 
>   Cc: <stable@kernel.org> # v2.6.25+
> 
> Al and Eric, I'll leave that up to you two.
> 
> 
> Here's my test matrix showing where messages end up as a result of a call to
> libaudit's audit_log_user_avc_message():
> 
> 		|	unpatched	patched
> ----------------+--------------------------------
> w/o audit=1 &	|	*dropped*	syslog
> w/o auditd	|
> 		|
> w/ audit=1 &	|	syslog		syslog
> w/o auditd	|
> 		|
> w/o audit=1 &	|	audit.log	audit.log
> w/ auditd	|
> 		|
> w/ audit=1 &	|	audit.log	audit.log
> w/ auditd	|
> 
> Thanks!
> 
>  kernel/audit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 91e53d0..f4f2773 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -613,7 +613,7 @@ static int audit_log_common_recv_msg(struct audit_buffer **ab, u16 msg_type)
>  	int rc = 0;
>  	uid_t uid = from_kuid(&init_user_ns, current_uid());
>  
> -	if (!audit_enabled) {
> +	if (!audit_enabled && msg_type != AUDIT_USER_AVC) {
>  		*ab = NULL;
>  		return rc;
>  	}
> -- 
> 1.8.3.2
> 
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2013-08-16 19:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26  1:02 [PATCH] audit: printk USER_AVC messages when audit isn't enabled Tyler Hicks
2013-08-16 19:05 ` Tyler Hicks [this message]
2013-08-19 23:59   ` Kees Cook
2014-01-22 17:39     ` Richard Guy Briggs
2013-08-20 14:45 ` Richard Guy Briggs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130816190558.GB3592@boyd \
    --to=tyhicks@canonical.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox