From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Guy Briggs Subject: spurious \n in session id helper [was: Re: user message limits] Date: Wed, 18 Sep 2013 11:10:47 -0400 Message-ID: <20130918151047.GC13968@madcap2.tricolour.ca> References: <1233100868.30154.103.camel@homeserver> <5267380.lufFp7267x@x2> <20130918022523.GB13962@madcap2.tricolour.ca> <1733218.gexlcdx6Tt@x2> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1733218.gexlcdx6Tt@x2> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Steve Grubb Cc: linux-audit@redhat.com, Justin Stephenson List-Id: linux-audit@redhat.com On Wed, Sep 18, 2013 at 10:25:57AM -0400, Steve Grubb wrote: > On Tuesday, September 17, 2013 10:25:23 PM Richard Guy Briggs wrote: > > On Tue, Sep 17, 2013 at 02:10:19PM -0400, Steve Grubb wrote: > > > and then session information: > > > audit_log_format(ab, " auid=%u ses=%u\n", auid, sessionid); > > > which is 32 characters...but I don't know why the \n is in there. That > > > should probably be deleted!! > > > > That is unexpected... added in 4d3fb709 when the session id was > > refactored (by eparis@localhost.localdomain nonetheless!). auditd seems > > to be doing the right thing when writing out /var/log/audit/audit.log > > though. > > Please drop the '\n' as I mentioned above. It doesn't belong there and wastes > room in the audit trail. Auditd strips all '\n' and it would run faster if it > didn't have to strip it out. Yup, I'll do that... > -Steve - RGB -- Richard Guy Briggs Senior Software Engineer Kernel Security AMER ENG Base Operating Systems Remote, Ottawa, Canada Voice: +1.647.777.2635 Internal: (81) 32635 Alt: +1.613.693.0684x3545