From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Guy Briggs Subject: Re: [PATCH] Audit: remove duplicate comments Date: Mon, 23 Sep 2013 11:28:35 -0400 Message-ID: <20130923152835.GS13968@madcap2.tricolour.ca> References: <1379922944-26520-1-git-send-email-gaofeng@cn.fujitsu.com> <52405B37.1010304@schaufler-ca.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <52405B37.1010304@schaufler-ca.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Casey Schaufler Cc: akpm@linux-foundation.org, linux-audit@redhat.com List-Id: linux-audit@redhat.com On Mon, Sep 23, 2013 at 08:16:07AM -0700, Casey Schaufler wrote: > On 9/23/2013 12:55 AM, Gao feng wrote: > > Remove it. > > Why? Is it inaccurate? Yes. It is a duplicate from 8 years ago that is no longer accurate. > > Signed-off-by: Gao feng > > --- > > kernel/audit.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/kernel/audit.c b/kernel/audit.c > > index 91e53d0..f94db2a 100644 > > --- a/kernel/audit.c > > +++ b/kernel/audit.c > > @@ -1067,13 +1067,6 @@ static void wait_for_auditd(unsigned long sleep_time) > > remove_wait_queue(&audit_backlog_wait, &wait); > > } > > > > -/* Obtain an audit buffer. This routine does locking to obtain the > > - * audit buffer, but then no locking is required for calls to > > - * audit_log_*format. If the tsk is a task that is currently in a > > - * syscall, then the syscall is marked as auditable and an audit record > > - * will be written at syscall exit. If there is no associated task, tsk > > - * should be NULL. */ > > - > > /** > > * audit_log_start - obtain an audit buffer > > * @ctx: audit_context (may be NULL) > > -- > Linux-audit mailing list > Linux-audit@redhat.com > https://www.redhat.com/mailman/listinfo/linux-audit - RGB -- Richard Guy Briggs Senior Software Engineer Kernel Security AMER ENG Base Operating Systems Remote, Ottawa, Canada Voice: +1.647.777.2635 Internal: (81) 32635 Alt: +1.613.693.0684x3545