From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Guy Briggs <rgb@redhat.com>
Subject: Re: [PATCH 1/2] audit: fix info leak in AUDIT_GET requests
Date: Mon, 30 Sep 2013 22:20:13 -0400
Message-ID: <20131001022013.GE13968@madcap2.tricolour.ca>
References: <1380571465-15440-1-git-send-email-minipli@googlemail.com>
	<1380571465-15440-2-git-send-email-minipli@googlemail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
Content-Disposition: inline
In-Reply-To: <1380571465-15440-2-git-send-email-minipli@googlemail.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Mathias Krause <minipli@googlemail.com>
Cc: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Mon, Sep 30, 2013 at 10:04:24PM +0200, Mathias Krause wrote:
> We leak 4 bytes of kernel stack in response to an AUDIT_GET request as
> we miss to initialize the mask member of status_set. Fix that.

Thank you.

> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Eric Paris <eparis@redhat.com>
> Cc: stable@vger.kernel.org  # v2.6.6+
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> ---
>  kernel/audit.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 7b0e23a..e237712 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -659,6 +659,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>  
>  	switch (msg_type) {
>  	case AUDIT_GET:
> +		status_set.mask		 = 0;
>  		status_set.enabled	 = audit_enabled;
>  		status_set.failure	 = audit_failure;
>  		status_set.pid		 = audit_pid;
> -- 
> 1.7.10.4
> 
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit

- RGB

--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer
Kernel Security
AMER ENG Base Operating Systems
Remote, Ottawa, Canada
Voice: +1.647.777.2635
Internal: (81) 32635
Alt: +1.613.693.0684x3545