From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Guy Briggs Subject: Re: [PATCH] audit: fix build error when disable audit Date: Thu, 19 Dec 2013 20:40:07 -0500 Message-ID: <20131220014007.GD14944@madcap2.tricolour.ca> References: <1387420469-27665-1-git-send-email-gaofeng@cn.fujitsu.com> <52B25CA8.8090806@cn.fujitsu.com> <20131220011956.GA14944@madcap2.tricolour.ca> <52B39FEB.8030308@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <52B39FEB.8030308@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org To: Gao feng Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org List-Id: linux-audit@redhat.com On 13/12/20, Gao feng wrote: > On 12/20/2013 09:19 AM, Richard Guy Briggs wrote: > > On 13/12/19, Gao feng wrote: > >> On 12/19/2013 10:34 AM, Gao feng wrote: > >>> kernel/capability.c: In function =E2=80=98SYSC_capset=E2=80=99: > >>> kernel/capability.c:280:2: warning: passing argument 1 of =E2=80=98= audit_log_capset=E2=80=99 makes integer from pointer without a cast [en= abled by default] > >>> audit_log_capset(new, current_cred()); > >>> ^ > >>> In file included from kernel/capability.c:10:0: > >>> include/linux/audit.h:400:20: note: expected =E2=80=98pid_t=E2=80= =99 but argument is of type =E2=80=98struct cred *=E2=80=99 > >>> static inline void audit_log_capset(pid_t pid, const struct cred= *new, > >>> ^ > >>> kernel/capability.c:280:2: error: too few arguments to function =E2= =80=98audit_log_capset=E2=80=99 > >>> audit_log_capset(new, current_cred()); > >>> ^ > >>> In file included from kernel/capability.c:10:0: > >>> include/linux/audit.h:400:20: note: declared here > >>> static inline void audit_log_capset(pid_t pid, const struct cred= *new, > >>> ^ > >>> make[1]: *** [kernel/capability.o] Error 1 > >> > >> BTW, bug introduced by commmit 26b81eb408c411d86c7cc93278fb88fbcd7= 85f65 > >> audit: Simplify and correct audit_log_capset > >=20 > > Yup, found it. Thanks for the patch. Since it isn't upstream yet,= I > > may merge it and rebase for linux-next. >=20 > thank you Richard, btw, do you have plan to push these changes to the= linux-next? Yes, that's where I'm putting all these, via Eric. - RGB -- Richard Guy Briggs Senior Software Engineer, Kernel Security, AMER ENG Base Operating Syst= ems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545