From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/2] audit: print error message when fail to create audit socket Date: Tue, 7 Jan 2014 16:53:35 -0800 Message-ID: <20140107165335.c276557412291786d745e0ab@linux-foundation.org> References: <1387249842-27793-1-git-send-email-gaofeng@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1387249842-27793-1-git-send-email-gaofeng@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org To: Gao feng Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, rgb@redhat.com, eparis@redhat.com List-Id: linux-audit@redhat.com On Tue, 17 Dec 2013 11:10:41 +0800 Gao feng wrote: > print the error message and then return -ENOMEM. > > ... > > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -1083,12 +1083,11 @@ static int __net_init audit_net_init(struct net *net) > pr_info("audit: initializing netlink socket in namespace\n"); > > aunet->nlsk = netlink_kernel_create(net, NETLINK_AUDIT, &cfg); > - if (aunet->nlsk == NULL) > - return -ENOMEM; > - if (!aunet->nlsk) > + if (aunet->nlsk == NULL) { > audit_panic("cannot initialize netlink socket in namespace"); > - else > - aunet->nlsk->sk_sndtimeo = MAX_SCHEDULE_TIMEOUT; > + return -ENOMEM; > + } > + aunet->nlsk->sk_sndtimeo = MAX_SCHEDULE_TIMEOUT; > return 0; > } What kernel version are these against? Something ancient, I expect - audit_net_init() doesn't exist. Please check current kernels, redo and resend the patches if anything needs changing?