From: Andrew Morton <akpm@linux-foundation.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: David Miller <davem@davemloft.net>,
rgb@redhat.com, eparis@redhat.com, linux-audit@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH] audit: Simplify by assuming the callers socket buffer is large enough
Date: Tue, 4 Mar 2014 14:50:37 -0800 [thread overview]
Message-ID: <20140304145037.d46ee775d293dd1ad60aa8e3@linux-foundation.org> (raw)
In-Reply-To: <87mwh5d1tf.fsf@xmission.com>
On Tue, 04 Mar 2014 14:41:16 -0800 ebiederm@xmission.com (Eric W. Biederman) wrote:
> David Miller <davem@davemloft.net> writes:
>
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Date: Tue, 4 Mar 2014 13:30:04 -0800
> >
> >> On Fri, 28 Feb 2014 20:50:19 -0800 ebiederm@xmission.com (Eric W. Biederman) wrote:
> >>
> >>>
> >>> Modify audit_send_reply to directly use a non-blocking send and
> >>> to return an error on failure (if anyone cares).
> >>>
> >>> Modify audit_list_rules_send to use audit_send_reply and give up
> >>> if we can not send a packet.
> >>>
> >>> Merge audit_list_rules into iaudit_list_rules_send as the code
> >>> is now sufficiently simple to not justify to callers.
> >>>
> >>> Kill audit_send_list, audit_send_reply_thread because using
> >>> a separate thread for replies is not needed when sending
> >>> packets syncrhonously.
> >>
> >> Nothing much seems to be happening here?
>
> Well you picked up the patch that fixes the worst of the bugs that I was
> complaining about. Beyond that I don't know what makes sense.
Oh, so I did. I wasn't planning on merging it myself, hoping that
someone who hasaclue will step in. Help.
next prev parent reply other threads:[~2014-03-04 22:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 18:49 [PATCH] audit: Use struct net not pid_t to remember the network namespce to reply in Eric W. Biederman
2014-03-01 1:11 ` Richard Guy Briggs
2014-03-01 4:34 ` Eric W. Biederman
2014-03-01 4:36 ` [PATCH] audit: Send replies in the proper network namespace Eric W. Biederman
2014-03-01 4:50 ` [RFC][PATCH] audit: Simplify by assuming the callers socket buffer is large enough Eric W. Biederman
2014-03-04 21:30 ` Andrew Morton
2014-03-04 21:51 ` David Miller
2014-03-04 22:41 ` Eric W. Biederman
2014-03-04 22:50 ` Andrew Morton [this message]
2014-03-10 3:06 ` [GIT PULL] namespaces fixes for 3.14-rcX Eric W. Biederman
2014-03-10 13:59 ` Eric Paris
2014-03-10 19:56 ` Eric W. Biederman
2014-03-16 18:36 ` Richard Guy Briggs
2014-03-05 0:21 ` [RFC][PATCH] audit: Simplify by assuming the callers socket buffer is large enough David Miller
2014-03-05 16:59 ` Steve Grubb
2014-03-05 17:57 ` LC Bruzenak
2014-03-05 18:06 ` Eric W. Biederman
2014-03-07 22:52 ` Eric Paris
2014-03-08 0:48 ` David Miller
2014-03-08 3:27 ` Steve Grubb
2014-03-08 6:34 ` David Miller
2014-03-08 3:56 ` Eric Paris
2014-03-10 19:30 ` David Miller
2014-03-10 21:57 ` Eric Paris
2014-03-16 18:19 ` [PATCH] audit: Send replies in the proper network namespace Richard Guy Briggs
2014-03-16 19:13 ` Richard Guy Briggs
2014-03-16 18:15 ` [PATCH] audit: Use struct net not pid_t to remember the network namespce to reply in Richard Guy Briggs
2014-03-16 19:12 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304145037.d46ee775d293dd1ad60aa8e3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).