From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Guy Briggs Subject: Re: [PATCH 04/14] fixup! audit: convert audit_exe to audit_fsnotify Date: Wed, 18 Jun 2014 16:18:45 -0400 Message-ID: <20140618201845.GF19353@madcap2.tricolour.ca> References: <69becd9fa692980a8852bafa01f08971330846d7.1403060033.git.rgb@redhat.com> <20140618093822.368a9bb1@flatline.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20140618093822.368a9bb1@flatline.rdu.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Eric Paris Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On 14/06/18, Eric Paris wrote: > On Tue, 17 Jun 2014 23:09:39 -0400 > Richard Guy Briggs wrote: > > > Remove unnecessary space. > > --- > > kernel/auditfilter.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c > > index 30091ce..94b6af1 100644 > > --- a/kernel/auditfilter.c > > +++ b/kernel/auditfilter.c > > @@ -551,7 +551,6 @@ static struct audit_entry > > *audit_data_to_entry(struct audit_rule_data *data, break; > > case AUDIT_EXE: > > case AUDIT_EXE_CHILDREN: > > - > > if (entry->rule.exe || f->val > PATH_MAX) > > goto exit_free; > > str = audit_unpack_string(&bufp, &remain, > > f->val); > > For patches like these, would you rather I just fold it into my patch > to keep a clean history, or would you rather I apply this little > whitespace change? (obviously fixing things like the subject) Well, it was labelled to simply be --autosquash(ed) by git rebase -i, so I'll just let git do that work later. I was intending to shepherd this patchset through... - RGB -- Richard Guy Briggs Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545