Re: [PATCH V5 08/13] sched: add a macro to ref all CLONE_NEW* flags

[Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On 14/10/06, Chen, Hanxiao wrote:
> 
> 
> > -----Original Message-----
> > From: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> > [mailto:containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org] On Behalf Of Richard Guy
> > Briggs
> > Sent: Monday, October 06, 2014 1:09 PM
> > To: linux-audit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> > Cc: eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; pmoore-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; aviro-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; sgrubb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org;
> > ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org
> > Subject: [PATCH V5 08/13] sched: add a macro to ref all CLONE_NEW* flags
> > 
> > ---
> >  include/uapi/linux/sched.h |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> > index 34f9d73..5aceba2 100644
> > --- a/include/uapi/linux/sched.h
> > +++ b/include/uapi/linux/sched.h
> > @@ -28,6 +28,12 @@
> >  #define CLONE_NEWUSER		0x10000000	/* New user namespace */
> >  #define CLONE_NEWPID		0x20000000	/* New pid namespace */
> >  #define CLONE_NEWNET		0x40000000	/* New network namespace */
> > +#define CLONE_NEW_MASK	( CLONE_NEWNS \
> > +			| CLONE_NEWUTS \
> > +			| CLONE_NEWIPC \
> > +			| CLONE_NEWUSER \
> > +			| CLONE_NEWPID \
> > +			| CLONE_NEWNET)	/* mask of all namespace type flags */
> >  #define CLONE_IO		0x80000000	/* Clone io context */
> 
> The name 'CLONE_NEW_MASK' may confuse readers.
> How about something like CLONE_NEW_MASK_ALL?

Fair enough.  Changed.

> Thanks,
> - Chen

- RGB

--
Richard Guy Briggs <rbriggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545