From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Guy Briggs Subject: Re: [PATCH][STABLE] audit: correct AUDIT_GET_FEATURE return message type Date: Wed, 29 Oct 2014 14:56:04 -0400 Message-ID: <20141029185604.GJ20866@madcap2.tricolour.ca> References: <20141029133506.GN26201@madcap2.tricolour.ca> <20141029155055.GC17232@kroah.com> <20141029162927.GG20866@madcap2.tricolour.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20141029162927.GG20866@madcap2.tricolour.ca> Sender: linux-kernel-owner@vger.kernel.org To: Greg KH Cc: stable@vger.kernel.org, linux-audit@redhat.com, linux-kernel@vger.kernel.org, sgrubb@redhat.com, pmoore@redhat.com List-Id: linux-audit@redhat.com On 14/10/29, Richard Guy Briggs wrote: > On 14/10/29, Greg KH wrote: > > On Wed, Oct 29, 2014 at 09:35:06AM -0400, Richard Guy Briggs wrote: > > > When an AUDIT_GET_FEATURE message is sent from userspace to the kernel, it > > > should reply with a message tagged as an AUDIT_GET_FEATURE type with a struct > > > audit_feature. The current reply is a message tagged as an AUDIT_GET > > > type with a struct audit_feature. > > > > > > This appears to have been a cut-and-paste-eo in commit b0fed40. > > > > > > Reported-by: Steve Grubb > > > Cc: stable@vger.kernel.org # v3.13-rc1 > > > Signed-off-by: Richard Guy Briggs > > > --- > > > kernel/audit.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > Why did you send this directly to stable@vger? That's not how to get a > > patch into the stable kernel trees... > > Sorry, you're right. It should be accepted upstream first. I'll go > back and make sure that gets done... Wait, it is upstream in v3.18-rc1, commit 9ef9151 Forgot the Cc: to stable in that commit log. > - RGB - RGB -- Richard Guy Briggs Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545