From: Mark Brown <broonie@kernel.org>
To: Paul Moore <paul@paul-moore.com>
Cc: Chen Gang <gang.chen.5i5j@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
eparis@redhat.com, linux-audit@redhat.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area
Date: Thu, 6 Nov 2014 12:11:43 +0000 [thread overview]
Message-ID: <20141106121143.GW8509@sirena.org.uk> (raw)
In-Reply-To: <283051037.h5QtGpv3rn@sifl>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Wed, Nov 05, 2014 at 12:43:01PM -0800, Paul Moore wrote:
> On Tuesday, November 04, 2014 11:09:52 PM Chen Gang wrote:
> > audit_file() is related with AUDITSYSCALL, not related with AUDIT, so
> > need move dummy one from !AUDIT area to !AUDITSYSCALL area. Or it will
> > cause issue if CONFIG_AUDIT with !CONFIG_AUDITSYSCALL.
> > The related error (with allmodconfig under tile):
> > CC fs/open.o
> > fs/open.c: In function 'SYSC_fchmod':
> > fs/open.c:530:3: error: implicit declaration of function 'audit_file'
> > [-Werror=implicit-function-declaration] audit_file(f.file);
> > ^
> What version of the kernel source are you looking at? I don't see the
> audit_file() function anywhere ...
This issue has been breaking ARMv8 defconfig builds in -next for a few
days now.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-11-06 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 15:09 [PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area Chen Gang
2014-11-05 20:43 ` Paul Moore
2014-11-06 3:19 ` Chen Gang
2014-11-06 16:50 ` Paul Moore
2014-11-06 12:11 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106121143.GW8509@sirena.org.uk \
--to=broonie@kernel.org \
--cc=eparis@redhat.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox