From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Guy Briggs Subject: Re: [PATCH] audit_tree: keep inode pinned Date: Wed, 12 Nov 2014 12:30:07 -0500 Message-ID: <20141112173007.GB28076@madcap2.tricolour.ca> References: <20141104102712.GA7088@tucsk.piliscsaba.szeredi.hu> <20141105165833.GE5902@madcap2.tricolour.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Miklos Szeredi Cc: Eric Paris , Al Viro , Linux Kernel Mailing List , linux-audit@redhat.com List-Id: linux-audit@redhat.com On 14/11/05, Miklos Szeredi wrote: > On Wed, Nov 5, 2014 at 5:58 PM, Richard Guy Briggs wrote: > > On 14/11/04, Miklos Szeredi wrote: > >> From: Miklos Szeredi > > > > Hi Miklos, > > > >> Audit rules disappear when an inode they watch is evicted from the cache. > >> This is likely not what we want. > >> > >> The guilty commit is "fsnotify: allow marks to not pin inodes in core", > >> which didn't take into account that audit_tree adds watches with a zero > >> mask. > >> > >> Adding any mask should fix this. > > > > Nice find! Do you have a quick reproducer to detect this? > > - reboot > - add tree rule > - echo 2 > /proc/sys/vm/drop_caches > > drop_caches doesn't guarantee dropping the inode from the cache, but > after a reboot it usually does. Perfect, thanks! That works as expected. While I was at it, I checked the audit_watch code and the pending "filter on process name" patches to make sure they didn't have the same problem. > Thanks, > Miklos - RGB -- Richard Guy Briggs Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545