From: Al Viro <viro@ZenIV.linux.org.uk>
To: Paul Moore <paul@paul-moore.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-audit@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Audit fixes for 3.19 #2
Date: Thu, 1 Jan 2015 00:01:49 +0000 [thread overview]
Message-ID: <20150101000149.GP22149@ZenIV.linux.org.uk> (raw)
In-Reply-To: <3787508.5gHb8qD3XR@sifl>
On Wed, Dec 31, 2014 at 05:08:12PM -0500, Paul Moore wrote:
> The getname/putname hacks work in the normal file case, but it falls apart
> when you start talking about AF_UNIX socket files where the filename string
> doesn't go through the getname/putname refcount tricks. In the past (no idea
> how far back this goes off the top of my head) this wasn't an issue since the
> code which recorded the filenames in the audit records was broken, but since
> we just "fixed" that problem, the AF_UNIX socket problem is now making an
> appearance.
>
> At least that is how it looks to me right now, if I'm wrong about this and I'm
> missing an obvious fix I'm all ears/eyes/etc.
Umm... How about just adding a function that would be used instead of
all those
struct filename filename = { .name = name };
and created an object that would be destroyed later by putname()?
next prev parent reply other threads:[~2015-01-01 0:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 20:33 [GIT PULL] Audit fixes for 3.19 #2 Paul Moore
2014-12-31 21:23 ` Linus Torvalds
2014-12-31 22:08 ` Paul Moore
2014-12-31 22:54 ` Linus Torvalds
2015-01-01 18:18 ` Paul Moore
2015-01-01 0:01 ` Al Viro [this message]
2015-01-01 18:22 ` Paul Moore
2015-01-01 18:41 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150101000149.GP22149@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).