Re: [PATCH v2 5/5] audit: replace getname()/putname() hacks with reference counters

Paul Moore
2015-01-22T16:24:10Z

On Thursday, January 22, 2015 11:09:42 AM Richard Guy Briggs wrote:
> On 15/01/22, Paul Moore wrote:
> > In order to ensure that filenames are not released before the audit
> > subsystem is done with the strings there are a number of hacks built
> > into the fs and audit subsystems around getname() and putname(). To
> > say these hacks are "ugly" would be kind.
> >
> > This patch removes the filename hackery in favor of a more
> > conventional reference count based approach. The diffstat below tells
> > most of the story; lots of audit/fs specific code is replaced with a
> > traditional reference count based approach that is easily understood,
> > even by those not familiar with the audit and/or fs subsystems.
> >
> > CC: viro@zeniv.linux.org.uk
> > CC: linux-fsdevel@vger.kernel.org
> > Signed-off-by: Paul Moore <pmoore@redhat.com>
>
> Noted change of bumping refcnt before passing back pointer to struct
> filename.
>
> Reviewed-by: Richard Guy Briggs <rgb@redhat.com>

Thanks for taking another look at the patch set.

--
paul moore
security @ redhat