From: Richard Guy Briggs <rgb@redhat.com>
To: Mustapha Abiola <hi@mustapha.org>
Cc: paul@paul-moore.com, linux-kernel@vger.kernel.org,
linux-audit@redhat.com
Subject: Re: Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken audit test fix for exec arg len
Date: Tue, 14 Jul 2015 10:24:54 -0400 [thread overview]
Message-ID: <20150714142454.GA29053@madcap2.tricolour.ca> (raw)
In-Reply-To: <CACy=+Ds+pDd8oGg-7rOvZsDeHerRWAey2aYj8T00Ds1y67Z6kg@mail.gmail.com>
On 15/07/12, Mustapha Abiola wrote:
> >From 55fae099d46749b73895934aab8c2823c5a23abe Mon Sep 17 00:00:00 2001
> From: Mustapha Abiola <hi@mustapha.org>
> Date: Sat, 11 Jul 2015 17:01:04 +0000
> Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken audit test fix for exec arg len
>
> Quick patch to fix the needless check of `len` being < 0 as its an unsigned int.
If you are able, it is much easier to use "git format-patch ..." and
"git send-email ...". Something in your workflow is double-spacing your
message... I echo Paul's recommendation...
> Signed-off-by: Mustapha Abiola <hi@mustapha.org>
>
> ---
>
> kernel/auditsc.c | 2 +-
>
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
>
> index e85bdfd..0012476 100644
>
> --- a/kernel/auditsc.c
>
> +++ b/kernel/auditsc.c
>
> @@ -1021,7 +1021,7 @@ static int audit_log_single_execve_arg(struct
> audit_context *context,
>
> * for strings that are too long, we should not have created
>
> * any.
>
> */
>
> - if (WARN_ON_ONCE(len < 0 || len > MAX_ARG_STRLEN - 1)) {
>
> + if (WARN_ON_ONCE(len > MAX_ARG_STRLEN - 1)) {
>
> send_sig(SIGKILL, current, 0);
>
> return -1;
>
> }
>
> --
>
> 1.9.1
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit
- RGB
--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
prev parent reply other threads:[~2015-07-14 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 2:11 Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken audit test fix for exec arg len Mustapha Abiola
2015-07-13 20:32 ` Paul Moore
2015-07-14 14:24 ` Richard Guy Briggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714142454.GA29053@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=hi@mustapha.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox