Linux-audit Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Guy Briggs <rgb@redhat.com>
To: linux-audit@redhat.com, linux-kernel@vger.kernel.org
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Subject: sparse bogus unexpected unlock warning? untag_chunk
Date: Sat, 8 Aug 2015 10:39:00 -0400	[thread overview]
Message-ID: <20150808143900.GC31940@madcap2.tricolour.ca> (raw)

After adding "C=1 CF=-D__CHECK_ENDIAN__" to my build script, sparse
produced the following warning:
	kernel/audit_tree.c:222:13: warning: context imbalance in 'untag_chunk' - unexpected unlock

It looks like a confused parser to me, because the locks appear to
balance properly from my review.

It doesn't say which lock triggered the warning, hash_lock, or
entry->lock.  The hash_lock is locked on call and returns in the same
state.  entry->lock looks fine.  The fsnotify marks look get/put
balanced too.

Is sparse spewing bogons, or am I?

- RGB

--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545

                 reply	other threads:[~2015-08-08 14:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150808143900.GC31940@madcap2.tricolour.ca \
    --to=rgb@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox