From: Steve Grubb <sgrubb@redhat.com>
To: Lev Stipakov <lstipakov@gmail.com>
Cc: linux-audit@redhat.com
Subject: Re: audit 1.7.18 and auparse_feed_has_data
Date: Mon, 1 Feb 2016 13:20:38 +0100 [thread overview]
Message-ID: <20160201132038.37565c63@ivy-bridge> (raw)
In-Reply-To: <n8ngmq$2tk$1@ger.gmane.org>
On Mon, 1 Feb 2016 13:48:42 +0200
Lev Stipakov <lstipakov@gmail.com> wrote:
> Hi,
>
> I have a Debian 7.9 which includes libaudit-devel-1.7.18. That
> version does not have auparse_feed_has_data(). Its implementation
> looks simple, however it uses au_lo, which is declared as static in
> auparse.c and therefore cannot be accessed outside of that file.
>
> I took auparse_feed_has_data() usage from audisp-example.c
>
> tv.tv_sec = 5;
> tv.tv_usec = 0;
> FD_ZERO(&read_mask);
> FD_SET(0, &read_mask);
> if (auparse_feed_has_data(au))
> retval= select(1, &read_mask, NULL, NULL, &tv);
> else
> retval= select(1, &read_mask, NULL, NULL, NULL);
>
> I noticed that old version of example plugin doesn't have
> auparse_feed_has_data() or select() calls
> (https://github.com/gdestuynder/audit-cef/blob/master/contrib/plugin/audisp-example.c#L104)
>
> What is the purpose of select/auparse_feed_has_data? Is it some kind
> of optimization or bug fix?
A little of both. See this thread for the background:
https://www.redhat.com/archives/linux-audit/2012-August/msg00025.html
> Since I have to support Debian 7 and
> probably have to stick to audit 1.7 headers, is it safe to use the
> "old way"?
>
> -Lev
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit
prev parent reply other threads:[~2016-02-01 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 11:48 audit 1.7.18 and auparse_feed_has_data Lev Stipakov
2016-02-01 12:20 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201132038.37565c63@ivy-bridge \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=lstipakov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox