From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH v2] s390: ensure that syscall arguments are properly
	masked on s390
Date: Tue, 28 Jun 2016 06:51:12 +0200
Message-ID: <20160628045112.GA3784@osiris>
References: <146703807642.15496.11673601281156224299.stgit@localhost>
	<CAGH-KgunDc74vuRa=z4yF8x5Ccxcery8-Ya1AqxdpAjaXEBxGQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com
	[10.5.110.25])
	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id u5S4pJ9k002022
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=NO)
	for <linux-audit@redhat.com>; Tue, 28 Jun 2016 00:51:20 -0400
Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com
	[148.163.158.5])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 9F0047F6A5
	for <linux-audit@redhat.com>; Tue, 28 Jun 2016 04:51:18 +0000 (UTC)
Received: from pps.filterd (m0098414.ppops.net [127.0.0.1])
	by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id
	u5S4mp3q120823
	for <linux-audit@redhat.com>; Tue, 28 Jun 2016 00:51:18 -0400
Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110])
	by mx0b-001b2d01.pphosted.com with ESMTP id 23sp3hqjce-1
	(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)
	for <linux-audit@redhat.com>; Tue, 28 Jun 2016 00:51:17 -0400
Received: from localhost
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <linux-audit@redhat.com> from <heiko.carstens@de.ibm.com>;
	Tue, 28 Jun 2016 05:51:16 +0100
Content-Disposition: inline
In-Reply-To: <CAGH-KgunDc74vuRa=z4yF8x5Ccxcery8-Ya1AqxdpAjaXEBxGQ@mail.gmail.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Paul Moore <pmoore@redhat.com>
Cc: linux-s390@vger.kernel.org, linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Mon, Jun 27, 2016 at 10:37:59AM -0400, Paul Moore wrote:
> On Mon, Jun 27, 2016 at 10:34 AM, Paul Moore <pmoore@redhat.com> wrote:
> > From: Paul Moore <paul@paul-moore.com>
> >
> > When executing s390 code on s390x the syscall arguments are not
> > properly masked, leading to some malformed audit records.
> >
> > Signed-off-by: Paul Moore <paul@paul-moore.com>
> > ---
> >  arch/s390/kernel/ptrace.c |   10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> The only change between v2 and the original patch is the use of
> is_compat_task() instead of the #ifdef, as suggested by Heiko.  Like
> before, I've added this patch to the audit#next branch; I think we
> have sorted all the feedback, but if any objections remain please let
> me know.

Thanks!

Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>