From: Richard Guy Briggs <rgb@redhat.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] audit: less stack usage for /proc/*/loginuid
Date: Wed, 2 Nov 2016 02:10:46 -0400 [thread overview]
Message-ID: <20161102061046.GI32641@madcap2.tricolour.ca> (raw)
In-Reply-To: <20161029160439.GE1246@avx2>
On 2016-10-29 19:04, Alexey Dobriyan wrote:
> %u requires 10 characters at most not 20.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Ack, looks reasonable to me. This has been there from the original
commit 1e2d1492e178 Serge Hallyn, Feb 2005.
> ---
>
> fs/proc/base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -1243,7 +1243,7 @@ static const struct file_operations proc_oom_score_adj_operations = {
> };
>
> #ifdef CONFIG_AUDITSYSCALL
> -#define TMPBUFLEN 21
> +#define TMPBUFLEN 11
> static ssize_t proc_loginuid_read(struct file * file, char __user * buf,
> size_t count, loff_t *ppos)
> {
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Kernel Security Engineering, Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635
next prev parent reply other threads:[~2016-11-02 6:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 16:04 [PATCH] audit: less stack usage for /proc/*/loginuid Alexey Dobriyan
2016-11-02 6:10 ` Richard Guy Briggs [this message]
2016-11-03 21:28 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102061046.GI32641@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=adobriyan@gmail.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox