From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: [BUG?] Exported private symbols in audit-userspace
Date: Thu, 26 Apr 2018 07:48:35 -0400
Message-ID: <20180426074835.487e23ae@ivy-bridge>
References: <CAJOtW+6XEG1CHBqFug=DbSYYyTRHjRmzrMyWJdCYs-T_hiR_gA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <CAJOtW+6XEG1CHBqFug=DbSYYyTRHjRmzrMyWJdCYs-T_hiR_gA@mail.gmail.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Yuri Gribov <tetra2005@gmail.com>
Cc: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Tue, 24 Apr 2018 21:32:33 +0100
Yuri Gribov <tetra2005@gmail.com> wrote:

> Hi,
> 
> Is there a reason for functions below to not be marked as hidden? They
> are not present in audit's public headers so technically there's no
> reason to export them from shlibs. I can see that some symbols (e.g.
> `audit_strsplit_r`) were marked as hidden before but then exported in
> https://github.com/linux-audit/audit-userspace/commit/aa4ed834b7db2f8c7c929bbec9750a6285cf5e39#diff-6085c87000f8d0b00a22de1631168e4e
> 
> _audit_archadded
> _audit_elf
> _audit_exeadded
> _audit_filterfsadded
> audit_msg
> _audit_permadded
> __audit_send
> audit_send
> audit_strsplit
> audit_strsplit_r
> _audit_syscalladded
> auparse_do_interpretation
> _auparse_free_interpretations
> auparse_interp_adjust_type
> _auparse_load_interpretations
> _auparse_lookup_interpretation
> __bss_start
> check_lru_cache
> compute_subject_key
> destroy_lru
> _edata
> _end
> _fini
> _init
> init_lru
> lru_evict

Thanks for pointing this out. The LRU symbols should not be public. I
fixed this in git. The rest are internal use that need to be public but
not advertised.

-Steve

> The issue was found using ShlibVisibilityChecker
> (https://github.com/yugr/ShlibVisibilityChecker).
> 
> Best regards,
> Yury Gribov
> 
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit