[BUG?] Exported private symbols in audit-userspace

[BUG?] Exported private symbols in audit-userspace

[Yuri Gribov]

Hi,

Is there a reason for functions below to not be marked as hidden? They
are not present in audit's public headers so technically there's no
reason to export them from shlibs. I can see that some symbols (e.g.
`audit_strsplit_r`) were marked as hidden before but then exported in
https://github.com/linux-audit/audit-userspace/commit/aa4ed834b7db2f8c7c929bbec9750a6285cf5e39#diff-6085c87000f8d0b00a22de1631168e4e

_audit_archadded
_audit_elf
_audit_exeadded
_audit_filterfsadded
audit_msg
_audit_permadded
__audit_send
audit_send
audit_strsplit
audit_strsplit_r
_audit_syscalladded
auparse_do_interpretation
_auparse_free_interpretations
auparse_interp_adjust_type
_auparse_load_interpretations
_auparse_lookup_interpretation
__bss_start
check_lru_cache
compute_subject_key
destroy_lru
_edata
_end
_fini
_init
init_lru
lru_evict

The issue was found using ShlibVisibilityChecker
(https://github.com/yugr/ShlibVisibilityChecker).

Best regards,
Yury Gribov

Re: [BUG?] Exported private symbols in audit-userspace

[Steve Grubb]

On Tue, 24 Apr 2018 21:32:33 +0100
Yuri Gribov <tetra2005@gmail.com> wrote:

> Hi,
> 
> Is there a reason for functions below to not be marked as hidden? They
> are not present in audit's public headers so technically there's no
> reason to export them from shlibs. I can see that some symbols (e.g.
> `audit_strsplit_r`) were marked as hidden before but then exported in
> https://github.com/linux-audit/audit-userspace/commit/aa4ed834b7db2f8c7c929bbec9750a6285cf5e39#diff-6085c87000f8d0b00a22de1631168e4e
> 
> _audit_archadded
> _audit_elf
> _audit_exeadded
> _audit_filterfsadded
> audit_msg
> _audit_permadded
> __audit_send
> audit_send
> audit_strsplit
> audit_strsplit_r
> _audit_syscalladded
> auparse_do_interpretation
> _auparse_free_interpretations
> auparse_interp_adjust_type
> _auparse_load_interpretations
> _auparse_lookup_interpretation
> __bss_start
> check_lru_cache
> compute_subject_key
> destroy_lru
> _edata
> _end
> _fini
> _init
> init_lru
> lru_evict

Thanks for pointing this out. The LRU symbols should not be public. I
fixed this in git. The rest are internal use that need to be public but
not advertised.

-Steve

> The issue was found using ShlibVisibilityChecker
> (https://github.com/yugr/ShlibVisibilityChecker).
> 
> Best regards,
> Yury Gribov
> 
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit