From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH ghak81 V3a] fixup! audit: collect audit task parameters
Date: Fri, 18 May 2018 08:02:33 +0200
Message-ID: <20180518060233.GA23531@gmail.com>
References: <03014913acdc9dc6fbbee0e16c937170fea86b06.1526577485.git.rgb@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <03014913acdc9dc6fbbee0e16c937170fea86b06.1526577485.git.rgb@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Linux-Audit Mailing List <linux-audit@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Eric Paris <eparis@redhat.com>, Paul Moore <paul@paul-moore.com>, Steve Grubb <sgrubb@redhat.com>, Ingo Molnar <mingo@redhat.com>
List-Id: linux-audit@redhat.com


* Richard Guy Briggs <rgb@redhat.com> wrote:

> Enable fork.c compilation with audit disabled.
> 
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> Hi Paul, this one got caught by the 0-day kbuildbot.  Can you squash it
> down if you haven't merged it yet?
> ---
>  kernel/fork.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 92ab849..ff82928 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1713,7 +1713,9 @@ static __latent_entropy struct task_struct *copy_process(
>  	p->start_time = ktime_get_ns();
>  	p->real_start_time = ktime_get_boot_ns();
>  	p->io_context = NULL;
> +#ifdef CONFIG_AUDITSYSCALL
>  	p->audit = NULL;
> +#endif /* CONFIG_AUDITSYSCALL */

Please, simply use:

  #endif

the comment is used for (much) larger blocks, to make it clear which block ends 
there if the top is not visible.

Thanks,

	Ingo