* [PATCH ghak81 V3a] fixup! audit: collect audit task parameters
@ 2018-05-17 17:20 Richard Guy Briggs
2018-05-18 0:29 ` Paul Moore
2018-05-18 6:02 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Richard Guy Briggs @ 2018-05-17 17:20 UTC (permalink / raw)
To: Linux-Audit Mailing List, LKML
Cc: Eric Paris, Paul Moore, Steve Grubb, Ingo Molnar,
Richard Guy Briggs
Enable fork.c compilation with audit disabled.
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
Hi Paul, this one got caught by the 0-day kbuildbot. Can you squash it
down if you haven't merged it yet?
---
kernel/fork.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/fork.c b/kernel/fork.c
index 92ab849..ff82928 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1713,7 +1713,9 @@ static __latent_entropy struct task_struct *copy_process(
p->start_time = ktime_get_ns();
p->real_start_time = ktime_get_boot_ns();
p->io_context = NULL;
+#ifdef CONFIG_AUDITSYSCALL
p->audit = NULL;
+#endif /* CONFIG_AUDITSYSCALL */
cgroup_fork(p);
#ifdef CONFIG_NUMA
p->mempolicy = mpol_dup(p->mempolicy);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH ghak81 V3a] fixup! audit: collect audit task parameters
2018-05-17 17:20 [PATCH ghak81 V3a] fixup! audit: collect audit task parameters Richard Guy Briggs
@ 2018-05-18 0:29 ` Paul Moore
2018-05-18 6:02 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Paul Moore @ 2018-05-18 0:29 UTC (permalink / raw)
To: Richard Guy Briggs
Cc: Linux-Audit Mailing List, LKML, Eric Paris, Steve Grubb,
Ingo Molnar
On Thu, May 17, 2018 at 1:20 PM, Richard Guy Briggs <rgb@redhat.com> wrote:
> Enable fork.c compilation with audit disabled.
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> Hi Paul, this one got caught by the 0-day kbuildbot. Can you squash it
> down if you haven't merged it yet?
See my comment in the original patch. I would just recommend
squashing this into the original patch the next time you post it.
> ---
> kernel/fork.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 92ab849..ff82928 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1713,7 +1713,9 @@ static __latent_entropy struct task_struct *copy_process(
> p->start_time = ktime_get_ns();
> p->real_start_time = ktime_get_boot_ns();
> p->io_context = NULL;
> +#ifdef CONFIG_AUDITSYSCALL
> p->audit = NULL;
> +#endif /* CONFIG_AUDITSYSCALL */
> cgroup_fork(p);
> #ifdef CONFIG_NUMA
> p->mempolicy = mpol_dup(p->mempolicy);
> --
> 1.8.3.1
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ghak81 V3a] fixup! audit: collect audit task parameters
2018-05-17 17:20 [PATCH ghak81 V3a] fixup! audit: collect audit task parameters Richard Guy Briggs
2018-05-18 0:29 ` Paul Moore
@ 2018-05-18 6:02 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2018-05-18 6:02 UTC (permalink / raw)
To: Richard Guy Briggs
Cc: Linux-Audit Mailing List, LKML, Eric Paris, Paul Moore,
Steve Grubb, Ingo Molnar
* Richard Guy Briggs <rgb@redhat.com> wrote:
> Enable fork.c compilation with audit disabled.
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> Hi Paul, this one got caught by the 0-day kbuildbot. Can you squash it
> down if you haven't merged it yet?
> ---
> kernel/fork.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 92ab849..ff82928 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1713,7 +1713,9 @@ static __latent_entropy struct task_struct *copy_process(
> p->start_time = ktime_get_ns();
> p->real_start_time = ktime_get_boot_ns();
> p->io_context = NULL;
> +#ifdef CONFIG_AUDITSYSCALL
> p->audit = NULL;
> +#endif /* CONFIG_AUDITSYSCALL */
Please, simply use:
#endif
the comment is used for (much) larger blocks, to make it clear which block ends
there if the top is not visible.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-18 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-17 17:20 [PATCH ghak81 V3a] fixup! audit: collect audit task parameters Richard Guy Briggs
2018-05-18 0:29 ` Paul Moore
2018-05-18 6:02 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).