From: Ondrej Mosnacek <omosnace@redhat.com>
To: linux-audit@redhat.com
Cc: Richard Guy Briggs <rgb@redhat.com>
Subject: [RFC PATCH ghak10 v2 3/4] timekeeping: Audit attempts to adjust the clock
Date: Tue, 19 Jun 2018 15:59:00 +0200 [thread overview]
Message-ID: <20180619135901.31473-4-omosnace@redhat.com> (raw)
In-Reply-To: <20180619135901.31473-1-omosnace@redhat.com>
(Intentionally not sending to the timekeeping maintainers just yet,
let's settle on the record contents/format first.)
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
---
kernel/time/timekeeping.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 4786df904c22..02097a7d225e 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -25,6 +25,7 @@
#include <linux/stop_machine.h>
#include <linux/pvclock_gtod.h>
#include <linux/compiler.h>
+#include <linux/audit.h>
#include "tick-internal.h"
#include "ntp_internal.h"
@@ -2315,6 +2316,16 @@ int do_adjtimex(struct timex *txc)
raw_spin_lock_irqsave(&timekeeper_lock, flags);
write_seqcount_begin(&tk_core.seq);
+ /* Only log audit event if the clock was changed/attempted to be changed.
+ * Based on the logic inside timekeeping_validate_timex().
+ * NOTE: We need to log the event before any of the fields get
+ * overwritten by the output values (__do_adjtimex() does not fail, so
+ * it is OK to do it here). */
+ if ( ( (txc->modes & ADJ_ADJTIME) && !(txc->modes & ADJ_OFFSET_READONLY))
+ || (!(txc->modes & ADJ_ADJTIME) && txc->modes)
+ || (txc->modes & ADJ_SETOFFSET))
+ audit_adjtime(txc);
+
orig_tai = tai = tk->tai_offset;
ret = __do_adjtimex(txc, &ts, &tai);
--
2.17.1
next prev parent reply other threads:[~2018-06-19 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 13:58 [RFC PATCH ghak10 v2 0/5] audit: Log modifying adjtimex(2) calls Ondrej Mosnacek
2018-06-19 13:58 ` [RFC PATCH ghak10 v2 1/4] audit: Add AUDIT_TIME_ADJUSTED record type Ondrej Mosnacek
2018-06-19 13:58 ` [RFC PATCH ghak10 v2 2/4] audit: Add the audit_adjtime() function Ondrej Mosnacek
2018-06-19 15:02 ` Richard Guy Briggs
2018-06-27 7:59 ` Ondrej Mosnacek
2018-06-19 13:59 ` Ondrej Mosnacek [this message]
2018-06-19 13:59 ` [RFC PATCH ghak10 v2 4/4] [OPTIONAL] Determine read-only in the validation function Ondrej Mosnacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619135901.31473-4-omosnace@redhat.com \
--to=omosnace@redhat.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox