From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 0/6] audit: Fix various races when tagging and untagging mounts Date: Tue, 3 Jul 2018 16:14:17 +0200 Message-ID: <20180703141417.fcf6znn3jjcvzaoa@quack2.suse.cz> References: <20180628164014.4925-1-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Paul Moore Cc: jack@suse.cz, rgb@redhat.com, amir73il@gmail.com, linux-audit@redhat.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org List-Id: linux-audit@redhat.com On Fri 29-06-18 14:01:44, Paul Moore wrote: > On Fri, Jun 29, 2018 at 7:44 AM Amir Goldstein wrote: > > On Thu, Jun 28, 2018 at 7:40 PM, Jan Kara wrote: > > > Hello, > > > > > > this series addresses the problems I have identified when trying to understand > > > how exactly is kernel/audit_tree.c using generic fsnotify framework. I hope > > > I have understood all the interactions right but careful review is certainly > > > welcome (CCing Al as he was the one implementing this code originally). > > > > > > The patches have been tested by a stress test I have written which mounts & > > > unmounts filesystems in the directory tree while adding and removing audit > > > rules for this tree in parallel and accessing the tree to generate events. > > > Still some real-world testing would be welcome. > > > > > > > This sort of stress test sound really useful to fanotify/inotify as well. > > Do plan to upstream that stress test? > > Agreed. > > I would be interested in having something like this in the > audit-testsuite so that we can include it in our regular regression > testing. > > * https://github.com/linux-audit/audit-testsuite OK, I'll look into integrating the test script into audit testsuite. Honza -- Jan Kara SUSE Labs, CR