Re: [PATCH 12/14] audit: Simplify locking around untag_chunk()

Richard Guy Briggs
2018-10-19T11:18:22Z

On 2018-10-19 10:22, Jan Kara wrote:
> On Thu 18-10-18 08:27:40, Richard Guy Briggs wrote:
> > > if (chunk->dead || !(entry->flags & FSNOTIFY_MARK_FLAG_ATTACHED)) {
> > > - mutex_unlock(&entry->group->mark_mutex);
> > > - if (new)
> > > - fsnotify_put_mark(new->mark);
> > > - goto out;
> > > + mutex_unlock(&audit_tree_group->mark_mutex);
> > > + return;
> >
> > This isn't an error, but more a question of style. Since the end of the
> > function has been simplified, this could just be "goto out_mutex", or
> > remove the one remaining "goto out_mutex" after the next patch and do
> > the same as here since other exits aren't so clean.
>
> Good point, I've switch this to "goto out_mutex". The result is attached.
> Can I add your Reviewed-by tag?

Yup.

> Jan Kara <jack@suse.com>

- RGB

--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635